Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S6967 FP: Issues should not be raised in autogenerated code #9261

Closed
hugoqribeiro opened this issue May 8, 2024 · 1 comment
Closed
Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.

Comments

@hugoqribeiro
Copy link

Description

S6967 is not respecting generated code.

Repro steps

This rule is being triggered on a controller defined in a file named Controllers.gen.cs, that includes the auto-generated comment, in a class that is annotated with GeneratedCode attribute.

//------------------------------------------------------------------------------
// <auto-generated>
//     This code was generated by a tool.
//     Changes to this file may cause incorrect behavior and will be lost if
//     the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------

[System.CodeDom.Compiler.GeneratedCode("Lithium", "8")]
public abstract partial class HomeControllerBase : AppControllerBase, IHomeController
{
    /// <inheritdoc />
    [Microsoft.AspNetCore.Mvc.ActionName(Common.Constants.Controllers.Home.Actions.Error)]
    [Microsoft.AspNetCore.Mvc.HttpGet(Common.Constants.Controllers.Home.Routes.Error)]
    public virtual System.Threading.Tasks.Task<Microsoft.AspNetCore.Mvc.IActionResult> ErrorAsync(int statusCode, System.Threading.CancellationToken cancellationToken = default)
    {
      // (...)
    }
}

Known workarounds

None.

Related information

  • SonarAnalyzer.CSharp version 9.25.0.90414
  • Visual Studio 17.9.6
  • .NET 8.0.204
  • Windows 10
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title S6967 rule applied to generated code Fix S6967 FP: Issues should not be raised in autogenerated code May 16, 2024
@mary-georgiou-sonarsource
Copy link
Contributor

mary-georgiou-sonarsource commented May 16, 2024

Hello again @hugoqribeiro,

I confirm this should not happen - we already have #8876 to fix this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Development

No branches or pull requests

2 participants