Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change .Verify to fail when no issues are reported #9237

Closed
Tim-Pohlmann opened this issue May 2, 2024 · 0 comments · Fixed by #9250
Closed

Change .Verify to fail when no issues are reported #9237

Tim-Pohlmann opened this issue May 2, 2024 · 0 comments · Fixed by #9250
Assignees
@Tim-Pohlmann
Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban

Comments

@Tim-Pohlmann
Copy link
Contributor

Currently .Verify does pass if no issues are reported. This can hide problems when source files are not detected correctly.
The behavior should be changed to fail if there are no issues reported. If zero issues are the expected outcome of the test, .VerifyNoIssueReported should be used instead, which makes the test more explicit.
@Tim-Pohlmann Tim-Pohlmann added the Type: Tooling Tools make us productive. label May 2, 2024
@Tim-Pohlmann Tim-Pohlmann added this to In progress in Best Kanban May 2, 2024
@Tim-Pohlmann Tim-Pohlmann self-assigned this May 2, 2024
This was referenced May 3, 2024
Merged
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 8, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 9, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 13, 2024
@Tim-Pohlmann Tim-Pohlmann moved this from Review in progress to In progress in Best Kanban May 13, 2024
@Tim-Pohlmann Tim-Pohlmann moved this from In progress to Review in progress in Best Kanban May 13, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 14, 2024
Best Kanban automation moved this from Review approved to Validate Peach May 14, 2024
@Tim-Pohlmann Tim-Pohlmann moved this from Validate Peach to Done in Best Kanban May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change .Verify to fail when no issues are reported SonarSource/sonar-dotnet
2 participants
@Tim-Pohlmann @CristianAmbrosini