Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Knex version 0.20 and above conflicts with no-invalid-await #889

Open
KristjanTammekivi opened this issue Nov 25, 2019 · 0 comments
Open

Comments

@KristjanTammekivi
Copy link

I want to report a bug.

SonarTS version: 1.9.0

Node.js version: 12.13.0

TypeScript version: 3.7.2

TSLint version: 5.18.0

Rule key: no-invalid-await

Reproducer

interface SomeCallable {
    (cb: Function): Promise<any>;
}

interface Builder {
    then: SomeCallable;
}

async function testme(knex: Builder) {
    await knex; // Type of 'await' operand must either be a valid promise or must not contain a callable 'then' member 
}

Expected behavior

Knex typings were changed in 0.20.0 so they don't inherit from Promise anymore, but there are still .then/.catch methods and should not warn (initially reported this in knex/knex#3516)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant