Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ResourceRepository related code #139

Open
tomeresk opened this issue Jun 15, 2020 · 0 comments
Open

Refactor the ResourceRepository related code #139

tomeresk opened this issue Jun 15, 2020 · 0 comments

Comments

@tomeresk
Copy link
Contributor

The ResourceRepository interface currently keeps a lot of logic in the respective implementations of each repository (S3, FS etc.).
We should refactor this to ideally have a simple abstraction layer over each repository that exposes the basic functions of working with it (get file, update file, list files etc.), and move the other logic currently in there to new abstractions (for example resource group manager, policy manager etc.).

More info and some of the discussion that prompted this issue can be found in the comments of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant