Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CircleCI builds for PRs from fork #67

Open
omerlh opened this issue Jan 7, 2019 · 3 comments
Open

Enable CircleCI builds for PRs from fork #67

omerlh opened this issue Jan 7, 2019 · 3 comments

Comments

@omerlh
Copy link
Contributor

omerlh commented Jan 7, 2019

I disabled them now because it's insecure - people can trigger builds that push images, or expose information. Need to investigate and decide how it is best to enable it again to test also PRs from a fork.

@Yshayy
Copy link

Yshayy commented Jan 9, 2019

You can define another trigger that is triggered by "pull request comment added" (it requires being repository owner/maintainer) for forks.

For extra protection, you can specify the codefresh.yaml of the master branch in the pipeline to prevent tinkering with the yaml file.

It's also possible to trigger a different pipeline that do the "promoting" of images on Dockerhub (from CF internal registry) and trigger it in another step via CF cli. (this pipeline can be completely private)

@omerlh
Copy link
Contributor Author

omerlh commented Jan 9, 2019

All sound like a good suggestions :) Thanks!

@omerlh omerlh changed the title Enable Codefresh builds for PRs from fork Enable CircleCI builds for PRs from fork Mar 6, 2019
@omerlh
Copy link
Contributor Author

omerlh commented Mar 6, 2019

Look like Kubernetes CI Robot can help us with that by adding the ok to test command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants