New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller memory leak #616

Open

shaikatz wants to merge 3 commits into master from fix-controller-memory-leak

Contributor

shaikatz commented Mar 29, 2021 •

edited

Since the reconciliation loop was added, the watcher not being disposed correctly leading to a memory leak.
Closes #617

Shai Katz added 2 commits

March 29, 2021 16:25


          Fix controller memory leak

3cbc22d


          Bump version

2596ec9

shaikatz requested a review from omerlh

March 29, 2021 13:33


          First subscribe again, then dispose

a5d8b28

omerlh previously approved these changes

View reviewed changes

shaikatz dismissed omerlh’s stale review via

a5d8b28

March 29, 2021 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment