Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] php extension req (ext-zip) in dev dependencies (composer.json) #395

Open
zerai opened this issue Sep 6, 2021 · 1 comment
Open
Assignees
Labels
dependencies Pull requests that update a dependency file easy-pick

Comments

@zerai
Copy link

zerai commented Sep 6, 2021

hi
is that correct?

    "require-dev": {
        "ext-zip": "*",
        "dama/doctrine-test-bundle": "^6.3",
        "doctrine/doctrine-fixtures-bundle": "^3.3",
        "fzaninotto/faker": "^1.9",
        "liip/test-fixtures-bundle": "^1.6",
        "matthiasnoback/symfony-dependency-injection-test": "^4.1",
       }

Additional context
here the PR

@pierredup
Copy link
Member

Hi @zerai I'm not sure why it was added to require-dev. We don't use the zip extension explicitly, so this definitely should be in the require section, but I also don't think we need it as part of any dev dependencies, so it would probably be safe to just remove it completely from the composer.json file

@pierredup pierredup added easy-pick dependencies Pull requests that update a dependency file and removed enhancement feature labels Sep 10, 2022
@pierredup pierredup added this to the 2.1.1 milestone Sep 10, 2022
@pierredup pierredup removed this from the 2.1.1 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file easy-pick
Projects
None yet
Development

No branches or pull requests

2 participants