Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What naming scheme would the users like to see for releases? #846

Closed
davidebeatrici opened this issue Dec 21, 2018 · 14 comments
Closed

What naming scheme would the users like to see for releases? #846

davidebeatrici opened this issue Dec 21, 2018 · 14 comments

Comments

@davidebeatrici
Copy link
Member

These are the current names of the files:

softether-vpn-portable-v5.01-9667-2018.12.21-windows-x64-pdbs.zip
softether-vpn-portable-v5.01-9667-2018.12.21-windows-x64.zip
softether-vpn-src-5.01.9667.tar.gz
softether-vpn-v5.01-9667-2018.12.21-windows-x64-pdbs.zip
softether-vpn-v5.01-9667-2018.12.21-windows-x86-pdbs.zip
softether-vpnclient-v5.01-9667-2018.12.21-windows-x86_x64-intel.exe
softether-vpnserver_vpnbridge-v5.01-9667-2018.12.21-windows-x86_x64-intel.exe

We would like to adopt a clear and concise naming scheme which can be used for automated build systems.

@Andy2244 @paskal

@metalefty
Copy link
Contributor

And create a directory like SoftEtherVPN-${VERSION} under the tarball. Please don't mess up current working directory.

@davidebeatrici
Copy link
Member Author

I agree.

@paskal
Copy link
Contributor

paskal commented Dec 26, 2018

I like your debian packages naming and I think you can use it for all platforms.

@davidebeatrici
Copy link
Member Author

softether-common_5.1.9667_amd64.deb
softether-vpnbridge_5.1.9667_amd64.deb
softether-vpnclient_5.1.9667_amd64.deb
softether-vpncmd_5.1.9667_amd64.deb
softether-vpnserver_5.1.9667_amd64.deb

You mean this one?

@metalefty
Copy link
Contributor

@Andy2244 you're just repeating what i said

@Andy2244
Copy link
Contributor

Andy2244 commented Jan 8, 2019

@Andy2244 you're just repeating what i said

Sorry just skimmed over the thread and missed your quick note about this :)

@RonNabuurs
Copy link
Contributor

Like @paskal said I really like the debian package naming.
I do think you should add something like the commit hash(the short hash) for builds that do not have a tag. So when somebody builds from master you would know which version and commit they use. This would also be easier for reporting issue etc.

So something like this:
Tags:

softether-common_5.1.9667_amd64.deb
softether-vpnbridge_5.1.9667_amd64.deb
softether-vpnclient_5.1.9667_amd64.deb
softether-vpncmd_5.1.9667_amd64.deb
softether-vpnserver_5.1.9667_amd64.deb

Build from master/other branches

softether-common_5.1.9667.3b85a11_amd64.deb
softether-vpnbridge_5.1.9667.3b85a11_amd64.deb
softether-vpnclient_5.1.9667.3b85a11_amd64.deb
softether-vpncmd_5.1.9667.3b85a11_amd64.deb
softether-vpnserver_5.1.9667.3b85a11_amd64.deb

This could be achieved by using the TWEAK version option from cmake.

@Andy2244
Copy link
Contributor

Andy2244 commented Jan 30, 2019

And create a directory like SoftEtherVPN-${VERSION} under the tarball. Please don't mess up current working directory.

The source release for 9668 is missing, softether-vpn-src-5.01.9668.tar.gz

Testing the automatic tar.gz with the new naming scheme i noticed that softether is the only package that extracts case sensitive folders, maybe this should be changed to softethervpn-${VERSION}?
I guess that's some convention of preventing case errors in scripts?

@Andy2244
Copy link
Contributor

Andy2244 commented Feb 8, 2019

@chipitsine Quick question, i don't see the manual created source releases i use for openwrt for the last two releases 9668/9 are those just minor updates so they have none or did something change how you release versions?

@chipitsine
Copy link
Member

@Andy2244 , they were not manual. they were supposed to be created by App Veyor, however we ran out of artifacts quota.

we are moving that to Azure Pipelines. thank for your patience

@Andy2244
Copy link
Contributor

Andy2244 commented Feb 8, 2019

np, thanks for the info was just wondering if something broke, was changed.

@Andy2244
Copy link
Contributor

Andy2244 commented Apr 9, 2019

@chipitsine Why does the current release still ignores what metalefty proposed?
Also 5.01.9670.tar.gz vs softether-vpn-src-5.01.9667.tar.gz ?
The archive still has no root folder like SoftEtherVPN-${VERSION} under the tarball.

@chipitsine
Copy link
Member

@Andy2244 , sorry. lack of time

chipitsine added a commit that referenced this issue Jul 10, 2019
Merge pull request #935: Change release packaging, fixes #846
@metalefty
Copy link
Contributor

This issue is still pinned. I would say this can be unpinned.

@chipitsine chipitsine unpinned this issue Jul 11, 2019
metalefty pushed a commit to metalefty/SoftEtherVPN that referenced this issue Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants