OpenVPN DhcpPushRoutes Error, Related to "vpn_gateway"

[neaese]

SoftEtherVPN/src/Cedar/Proto_OpenVPN.c

Line 2478 in 6a170ac

",route %r %r vpn_gateway",

The gateway ip address is not replaced with [vpn_gateway], causing the routing table to be incorrectly configured on the mobile phone client.
Error message :"route destinations other than vpn_gateway or net_gateway are not supported"

[parkycai]

	if (r->Exists)
 	{
 		Format(l3_options, sizeof(l3_options),
-			",route %r %r vpn_gateway",
-			&r->Network, &r->SubnetMask);
+			",route %r %r %r",
+			&r->Network, &r->SubnetMask, &r->Gateway);
 
 		StrCat(option_str, sizeof(option_str), l3_options);
 	}

[officialh1]

What version are you using? This code is commented out in the somewhat recent pull that I have...:

if	0	// Currently disabled
										// If the default gateway is not specified, add the static routing table
										// entry for the local IP subnet
										IP local_network;
										IP client_ip;
										IP subnet_mask;

										UINTToIP(&client_ip, cao->ClientAddress);
										UINTToIP(&subnet_mask, cao->SubnetMask);

										Zero(&local_network, sizeof(IP));
										IPAnd4(&local_network, &client_ip, &subnet_mask);

										Format(l3_options, sizeof(l3_options),
										       ",route %r %r vpn_gateway",
										       &local_network,
										       &cao->SubnetMask);

										StrCat(option_str, sizeof(option_str), l3_options);
#endif

[parkycai]

What version are you using? This code is commented out in the somewhat recent pull that I have...:

if	0	// Currently disabled
										// If the default gateway is not specified, add the static routing table
										// entry for the local IP subnet
										IP local_network;
										IP client_ip;
										IP subnet_mask;

										UINTToIP(&client_ip, cao->ClientAddress);
										UINTToIP(&subnet_mask, cao->SubnetMask);

										Zero(&local_network, sizeof(IP));
										IPAnd4(&local_network, &client_ip, &subnet_mask);

										Format(l3_options, sizeof(l3_options),
										       ",route %r %r vpn_gateway",
										       &local_network,
										       &cao->SubnetMask);

										StrCat(option_str, sizeof(option_str), l3_options);
#endif

I'm using [5.01.9674] which is used in OpenWRT. I noticed that the above code is to fix classless routing table push code, which is already fixed in 5.02.5180.

[chipitsine]

yes, I need to fix release machinery and emit new release
hopefully will do that soon

[parkycai]

yes, I need to fix release machinery and emit new release hopefully will do that soon

great!

What version are you using? This code is commented out in the somewhat recent pull that I have...:

if	0	// Currently disabled
										// If the default gateway is not specified, add the static routing table
										// entry for the local IP subnet
										IP local_network;
										IP client_ip;
										IP subnet_mask;

										UINTToIP(&client_ip, cao->ClientAddress);
										UINTToIP(&subnet_mask, cao->SubnetMask);

										Zero(&local_network, sizeof(IP));
										IPAnd4(&local_network, &client_ip, &subnet_mask);

										Format(l3_options, sizeof(l3_options),
										       ",route %r %r vpn_gateway",
										       &local_network,
										       &cao->SubnetMask);

										StrCat(option_str, sizeof(option_str), l3_options);
#endif

I believe the code inside the 'else' block above should be disabled. In the absence of default gateway, you should use classless routing to specify routing information for certain network segments.

[chipitsine]

@parkycai , I've just pushed new release https://github.com/SoftEtherVPN/SoftEtherVPN/releases/tag/5.02.5181