Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency breaking for Windows installations #16

Open
dpesce opened this issue Dec 29, 2023 · 4 comments
Open

Dependency breaking for Windows installations #16

dpesce opened this issue Dec 29, 2023 · 4 comments
Assignees

Comments

@dpesce
Copy link
Collaborator

dpesce commented Dec 29, 2023

Currently the ehtim package has paramsurvey as a dependency, which in turn uses the resource package:

https://docs.python.org/3/library/resource.html

This package does not work on Windows machines, so installation of ngehtsim breaks.

@wumpus
Copy link

wumpus commented Dec 30, 2023

I don't have WIndows to test, but I'd be happy to hack together a Windows version if I have a person to test. It's just 2 things.

@dpesce
Copy link
Collaborator Author

dpesce commented Jan 3, 2024

I also don't have a Windows machine to test it on; this issue was initially uncovered through unit tests being run with Github actions in a Windows environment. I think @ryan-chaves-sao may have a Windows machine though?

@wumpus
Copy link

wumpus commented Jan 3, 2024

I think I can YOLO this one in a pull request, it's simple enough of a change. Let me finish being on vacation first (back Jan 9 -- hello from Tokyo.)

@wumpus wumpus self-assigned this Jan 3, 2024
@ryan-chaves-sao
Copy link

I believe it's due to paramsurvey's use of the resource module, which appears to be UNIX-only.

(.venv) > pytyhon .\gendata.py
Warning: No NFFT installed!
Warning: scikit-image not installed! Cannot use hough transform
Warning: networkx not installed! Cannot use image_agreements()
Traceback (most recent call last):
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\sims\simulation002\gendata.py", line 2, in <module>
    import ehtim as eh
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\.venv\lib\site-packages\ehtim\__init__.py", line 45, in <module>
    import ehtim.survey
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\.venv\lib\site-packages\ehtim\survey.py", line 25, in <module>
    import paramsurvey
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\.venv\lib\site-packages\paramsurvey\__init__.py", line 6, in <module>
    from . import psmultiprocessing
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\.venv\lib\site-packages\paramsurvey\psmultiprocessing.py", line 10, in <module>
    from . import utils
  File "C:\Users\RChaves\OneDrive - Smithsonian Institution\projects\ngEHT\ngeht-arrayperformance-sims\.venv\lib\site-packages\paramsurvey\utils.py", line 7, in <module>
    import resource
ModuleNotFoundError: No module named 'resource'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants