Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to do testing going forward? #156

Open
illume opened this issue Jan 11, 2024 · 3 comments
Open

How to do testing going forward? #156

illume opened this issue Jan 11, 2024 · 3 comments

Comments

@illume
Copy link
Collaborator

illume commented Jan 11, 2024

Hey hey.

How do you think we should do testing going forward?

I see NextJs mentions e2e testing with playwright.
https://nextjs.org/docs/pages/building-your-application/testing/playwright
I've been using that on another project, and it's quite nice.

Maybe storybook stories for the presentation components?

How about API testing? Any ideas there? e2e testing will cover it somewhat.


I can set up running lint / type checking and such on github actions, and also contribute some basic tests once some decisions are made.

@justinpac
Copy link
Collaborator

Thank you for starting this issue! Siddhesh and I talked about this. We have a major deadline on Jan 24th. After that we will lay the foundation for a full testing suite, and I will be blocking any PRs without testing.

I see that you offered to set up lint/type checking on GitHub actions and contribute some basic tests. PLEASE feel free to get something started! We will need it. Siddhesh mentioned trying out SonarLint or SonarQube but I am not sure what his progress is on that. @siddheshraze what do you think?

@illume
Copy link
Collaborator Author

illume commented Jan 14, 2024

I see that you offered to set up lint/type checking on GitHub actions and contribute some basic tests. PLEASE feel free to get something started!

Cool, I'll get some basic checks going via github workflow CI.

@illume
Copy link
Collaborator Author

illume commented Jan 17, 2024

@siddheshraze and I had a meeting...

After lint/typecheck ones in CI I'm going to do some storybook stories.
Then after I can run it locally, I'll start on some e2e tests with playwright.

(Then maybe later we can do some jest based unit tests.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants