Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slather incompatible with Variant tests #514

Open
gaige opened this issue May 10, 2022 · 1 comment
Open

Slather incompatible with Variant tests #514

gaige opened this issue May 10, 2022 · 1 comment

Comments

@gaige
Copy link

gaige commented May 10, 2022

We are using variant testing in some of our test plans (for example: one plan requiring USan and another using ASan), which results in the following Build directory structure:

Build/Products/Variant-ASan-UBSan/Debug-iphonesimulator/CTUtilsTest.xctest
Build/Products/Variant-USan-UBSan/Debug-iphonesimulator/CTUtilsTest.xctest

In this case the find_binary_files fails to find the variants (reasonable, since there's no way to tell it which one to choose anyway). This problem may be especially acute if using build_without_testing, since you're guaranteed to have the variants carried along in that case.

I've not found a way to be more specific about the binaries in order to accommodate this, so we're running a separate set of coverage tests (which should yield the same results) with a single test binary, as opposed to requiring the variants. However, there may be others who run into this in the future, and I figured I'd see if I could save someone time at least in acknowledging this.

I'm not sure exactly what the fix is here, other than to provide a way to specify variants explicitly.

@andrewsexcellent
Copy link

Running against the same issue, the tests create Build/Products/Variant-ASan and then Slather fails with No product binary found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants