Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Minor visual issues with floating images/callouts and horizontal lines #212

Open
Jnosh opened this issue Jun 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Jnosh
Copy link

Jnosh commented Jun 4, 2023

Describe the bug

Two minor visual issues I noticed while documenting #207:

  1. There is no padding/margin between a floating image and a horizontal line when the Note->Images->Clear Images->Horizontal Lines setting is activated. It would be nice if the image had the same margin/padding towards the line as for a non-floating image. Also affects floating callouts since they are also affected by Note->Images->Clear Images->Horizontal Lines. (Maybe the Clear Images settings should be move to the Horizonal Line and Headers setting sections instead as they affect both floating images and floating callouts)

Not floating, has nice distance from horizontal line:

Screenshot 2023-06-05 at 00 22 02

Floating image, content is larger than image height - content has a nice distance to horizontal line:

Screenshot 2023-06-05 at 00 25 53

Floating image where content next to image is shorter - image goes directly up to horizontal line with no margin or padding between:

Screenshot 2023-06-05 at 00 21 22
  1. With default settings, where images can float next to horizontal lines, the horizontal line symbol can overlap with a wider image. I think the line symbol is always placed in the center of the page which then overlaps with a floating image if it is wider than 50% of the page width itself. The line symbol should ideally be placed in the center of the horizontal line so it adjusts position if the horizontal line is shortened due to some floating content. Again, this affect both images and callouts.
Screenshot 2023-06-05 at 00 28 55

OS

  • [x ] Desktop, macOS Ventura 13.5
  • [not tested] Mobile

Versions

  • Obsidian Version: 1.3.5
  • ITS Theme Version: 1.0.32
@Jnosh Jnosh added the bug Something isn't working label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Hiatus
Development

No branches or pull requests

2 participants