Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block the PR emission if the PR description has not yet been changed #124

Open
sledigabel opened this issue Jan 31, 2024 · 1 comment
Open

Block the PR emission if the PR description has not yet been changed #124

sledigabel opened this issue Jan 31, 2024 · 1 comment
Assignees
@Dan7-7-7

Comments

@sledigabel
Copy link
Contributor

sledigabel commented Jan 31, 2024 •
edited

A suggestion from my teammate @lnascimentosilva shortly after using turbolift for the first time:

It would make sense to block the create-prs or at least ask for confirmation if the REAME.md file containing the PR description has not been modified yet.
The rationale is that users while finding their feet with turbolift may not realise they are filing a legit PR to a bunch of repos.
@Dan7-7-7
Copy link
Collaborator

This might be less of an issue once we enable updating PR descriptions - but I still think it's a good idea.

@Dan7-7-7 Dan7-7-7 self-assigned this Apr 10, 2024
@Dan7-7-7 Dan7-7-7 mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dan7-7-7 Dan7-7-7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sledigabel @Dan7-7-7