Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

API breaking changes tracking (May 2020) #1370

Open
9 of 12 tasks
louischan-oursky opened this issue Apr 29, 2020 · 3 comments
Open
9 of 12 tasks

API breaking changes tracking (May 2020) #1370

louischan-oursky opened this issue Apr 29, 2020 · 3 comments
Projects

Comments

@louischan-oursky
Copy link
Contributor

louischan-oursky commented Apr 29, 2020

  • Removed the concept of current identity
    • Remove identity from auth response
    • Remove skygear_identity from OIDC id_token
    • Remove identity headers from session resolver endpoint
    • Remove identity info from sessions (used by hooks & session APIs)
  • Supply 'is anonymous user' flag
    • anonymous: boolean in API user models
    • X-Skygear-User-Anonymous in session resolver headers.
  • Changed shape of identities returned by list identity Auth API
    • type: identity type
    • claims: OIDC standard claims combined with custom Skygear claims
  • Removed MFA Auth API for now (TBC)
  • Changed signup/add Login ID Auth API to accept only one login ID (instead of multiple)
  • Changed updating login ID to trigger single 'identity update' event, instead of 'identity add' and 'identity remove' events
@kiootic kiootic added this to To do in May 2020 May 4, 2020
@kiootic kiootic changed the title Handle breaking change of identity API breaking changes tracking (May 2020) May 14, 2020
@kiootic
Copy link
Contributor

kiootic commented May 14, 2020

@louischan-oursky @carmenlau Here's the planned breaking changes we would make from what I remembered. Please help to check if there is any missing points so that we can track it for implementation/discuss it in next meeting.

@louischan-oursky
Copy link
Contributor Author

louischan-oursky commented May 14, 2020

I remember I proposed to remove identity info (including claims) in headers and hook context.

@louischan-oursky
Copy link
Contributor Author

@kiootic We also need to tell the developer the user is anonymous or not, in the SDK, in hook context, and in headers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
May 2020
  
To do
Development

No branches or pull requests

2 participants