Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Branches: and PR is merged, rebase detection can fail and cause pr to be re-created #174

Open
jerry-skydio opened this issue Apr 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jerry-skydio
Copy link
Collaborator

Upload change from branch A but target other branch B with Branches:. When change merges and you fetch B again, revup continues to upload the PR to B, does the cherry-pick, finds that it succeeds and produces an empty commit, then finds the patch-id of the empty commit, compares against original, and mistakenly finds that it changed and thus re-uploads.

@jerry-skydio jerry-skydio added the bug Something isn't working label Apr 3, 2024
@jerry-skydio
Copy link
Collaborator Author

this seems to only happen for relative chains that get targeted to a different branch. possibly only when the relative change forces a push of the parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant