Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upload] Prs get auto-closed when changes are reordered sometimes #170

Open
jerry-skydio opened this issue Mar 14, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jerry-skydio
Copy link
Collaborator

This seems to happen when two PRs are in a relative chain and their order is swapped.

I think we can do something tricky where we push a temporary intermediate fake commit to break dependencies then push again to send the real changes. ghstack does something similar here ezyang/ghstack#23

@jerry-skydio jerry-skydio added the bug Something isn't working label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant