Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挕 Accepted changes for expressions in docs #15

Open
AyhamAl-Ali opened this issue Jul 3, 2021 · 4 comments 路 May be fixed by #35 or SkriptLang/Skript#5687
Open

馃挕 Accepted changes for expressions in docs #15

AyhamAl-Ali opened this issue Jul 3, 2021 · 4 comments 路 May be fixed by #35 or SkriptLang/Skript#5687
Labels
backend Issues that require backend code changes (java) enhancement Feature request, an issue about something that could be improved, or a PR improving something. frontend Issues that require frontend code changes (HTML, CSS, JS) PR Available priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@AyhamAl-Ali
Copy link
Member

This is a useful information to be added in the docs is to know what are the accepted changes you can do for each expression.

Example
image

Accepted Changes is a bit too long, could someone suggest a shorter name :)

I will try to push a PR for that as soon as I can.
@APickledWalrus APickledWalrus added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jul 3, 2021
@TPGamesNL
Copy link
Member

A shorter name could be Change modes

@AyhamAl-Ali AyhamAl-Ali transferred this issue from SkriptLang/Skript Jan 23, 2023
@Fusezion
Copy link

Changers seems like a better name than Accepted Changes or Change Modes

@APickledWalrus
Copy link
Member

I think this would best be achieved through an annotation. There are factors that influence what changers are available so I don't think we would be able to accurately "predict" them (hence my suggestion for an annotation).

@AyhamAl-Ali
Copy link
Member Author

AyhamAl-Ali commented Jan 23, 2023 •
edited

I had attempted to implement this before but there wasn't an easy way to do it without Reflrections therefore either add it using Annotations or by adding a new method such as acceptedChangers to return all accepted changers

@AyhamAl-Ali AyhamAl-Ali added backend Issues that require backend code changes (java) frontend Issues that require frontend code changes (HTML, CSS, JS) labels Jan 23, 2023
@AyhamAl-Ali AyhamAl-Ali changed the title [Suggestion] Accepted changes for expressions in docs 馃挕 Accepted changes for expressions in docs Jan 24, 2023
@AyhamAl-Ali AyhamAl-Ali linked a pull request May 10, 2023 that will close this issue
Draft
@AyhamAl-Ali AyhamAl-Ali linked a pull request May 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issues that require backend code changes (java) enhancement Feature request, an issue about something that could be improved, or a PR improving something. frontend Issues that require frontend code changes (HTML, CSS, JS) PR Available priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
4 participants
@AyhamAl-Ali @APickledWalrus @TPGamesNL @Fusezion