Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to Skript JARs #6622

Closed
1 task done
Romitou opened this issue Apr 28, 2024 · 3 comments
Closed
1 task done

Add version to Skript JARs #6622

Romitou opened this issue Apr 28, 2024 · 3 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Romitou
Copy link
Sponsor Contributor

Romitou commented Apr 28, 2024

Suggestion

My suggestion is to modify the build.gradle so that it automatically includes the Skript version in the name of the output JAR, and maybe even other information such as the release flavor.

Why?

Skript users will no longer be confused when two JARs with the same name have different versions. So this is more of a QoL suggestion, making it easier to handle the many versions of Skript.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@ShaneBeee
Copy link
Contributor

I agree ... I would love to see this!

@Asleeepp
Copy link
Contributor

Asleeepp commented Apr 28, 2024 •
edited

Agreed! Hate to see Skript (number).jar saved to my file explorer everytime i update., would much rather there be the version

@Fusezion
Copy link
Contributor

Agreed! Hate to see Skript (number).jar saved to my file explorer everytime i update., would much rather there be the version

just rename your file and stop keeping copies...

but yes I agree would love to see version added to jar at least

@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). good first issue An issue that would be good for a first-time contributor to make a PR for labels Apr 28, 2024
@Moderocky Moderocky mentioned this issue May 1, 2024
Merged
@Moderocky Moderocky added PR available Issues which have a yet-to-be merged PR resolving it and removed good first issue An issue that would be good for a first-time contributor to make a PR for labels May 1, 2024
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Moderocky @ShaneBeee @AyhamAl-Ali @APickledWalrus @Romitou @Fusezion @Asleeepp