Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Builder Section #6536

Open
1 task done
erenkarakal opened this issue Apr 4, 2024 · 4 comments
Open
1 task done

Item Builder Section #6536

erenkarakal opened this issue Apr 4, 2024 · 4 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@erenkarakal
Copy link
Contributor

erenkarakal commented Apr 4, 2024

Suggestion

A section that allows you to build an item.

new %itemtype% [stored in %-objects%]:
  name: "&chello"
  lore:
    "A"
    "B"
  enchantments:
    sharpness 10
give [the] [last] item to player

Why?

While this doesn't exactly fit Skript's purpose of making an English programming language, it removes the need of storing the item in a variable and spamming sets every line. Using 50 expressions in 1 line doesn't end well either.

Other

In my opinion Skript should have more builders like SecSpawn and this is a good place to start.

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@7othifaPS
Copy link

that would be cool to have!

@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Apr 4, 2024
@sovdeeth
Copy link
Member

sovdeeth commented Apr 4, 2024

I think this kind of shatters Skript central conceit of a clause per line into dust. I'd rather see something more like the spawn effect section:

Set {_i} to a diamond sword:
    enchant item with unbreaking 3
    set name of item to "test"

Etc

@erenkarakal
Copy link
Contributor Author

I think this kind of shatters Skript central conceit of a clause per line into dust. I'd rather see something more like the spawn effect section:

Set {_i} to a diamond sword:
    enchant item with unbreaking 3
    set name of item to "test"

Etc

i thought about that but i didnt think you could make expression sections

@Moderocky
Copy link
Member

i thought about that but i didnt think you could make expression sections

Fixing this would be a good place to start.

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. and removed feature Pull request adding a new feature. labels Apr 4, 2024
@AyhamAl-Ali AyhamAl-Ali changed the title Item Builder Item Builder Section Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

4 participants