Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Deleting a character record leaves a note record #88

Open
Morgul opened this issue Oct 27, 2020 · 1 comment
Open

[Bug Report] Deleting a character record leaves a note record #88

Morgul opened this issue Oct 27, 2020 · 1 comment
Labels
bug core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. low-priority
Milestone
Future

Comments

@Morgul
Copy link
Member

Morgul commented Oct 27, 2020

Currently, when you delete a character record from the database, it doesn't remove the corresponding note record. This seems to be because the column is set to ON DELETE RESTRICT.

This should be ON DELETE CASCADE.
@Morgul Morgul added bug low-priority core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. labels Oct 27, 2020
@Morgul Morgul added this to the v2.0.0 milestone Oct 27, 2020
@Morgul Morgul changed the title [Bug Report] Deleting a character leaves as note record [Bug Report] Deleting a character leaves a note record Oct 27, 2020
@Morgul
Copy link
Member Author

Morgul commented Oct 27, 2020 •
edited

To clarify, the desired behavior:

  1. If a note is referenced by a character, the note cannot be deleted.
  2. If a character is deleted, the corresponding note is deleted.

Whatever database magic makes that happen is what we need.

@Morgul Morgul changed the title [Bug Report] Deleting a character leaves a note record [Bug Report] Deleting a character record leaves a note record Oct 27, 2020
@Morgul Morgul modified the milestones: v2.0.0, Future Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core Related to the core code of RPGKeeper good first issue A good issue for a new developer to tackle. low-priority
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@Morgul