Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPUS codec does not support sample rate of 44100 #164

Open
PatrykMis opened this issue Nov 6, 2022 · 0 comments
Open

OPUS codec does not support sample rate of 44100 #164

PatrykMis opened this issue Nov 6, 2022 · 0 comments
Labels

Comments

@PatrykMis
Copy link
Contributor

44100 sample rate should be removed from constants and at least set by if statement which checks for chosen encoder/format.

Current implementation, if set to OPUS, saves recording in 48000 causing playback to be 4% faster than it should be. It is very audible and also noticeable in recording length.

The solution is to set recording sample rate strictly to 48000 if user choose OPUS, or to provide resampling (https://developer.android.com/ndk/guides/audio/sampling-audio).

I will check if I will be able to do first solution myself and create pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants