Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeProcessor Architecture Update #423

Open
1 of 7 tasks
jleandroperez opened this issue Dec 5, 2014 · 0 comments
Open
1 of 7 tasks

ChangeProcessor Architecture Update #423

jleandroperez opened this issue Dec 5, 2014 · 0 comments

Comments

@jleandroperez
Copy link
Contributor

We've got several issues that would require tracking the number of retries per change, and/or could use some optimizations in the way we store pending changesets:

Plus, it would be great to:

  • Update all of the code we've got that uses the Change Dictionary, to use explicit getters, instead of relying on key-value.
  • Encapsulate SPChangeProcessor's keyWithoutNamespaces method into a proper entity.
  • Potentially, deprecate the helper SPPersistentMutableSet. Only if we do manage to keep the same functionality, without performance impact.

Let's address this scenario in a feature branch:

  • Wrap the remote changes into a new class: SPChange
  • Refactor / Rebuild SPPersistentMutableDictionary to handle SPChange. Potentially, this means that we'll build a class called SPChangeStorage
  • Measure performance impact against the current mechanism.
  • Implement fetch requests to replicate the current usage we've got in SPPersistentMutableSet, and measure its performance with over 10k entities.
  • Update Unit Tests
  • Integrate with the rest of the library.
  • Make sure that legacy metadata is migrated into the new mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant