-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Unexpected behavior with subcommand in quotes #2254
Comments
@LenAnderson does the abort not immediately stop the execution in the new parser when encountered in a subcommand? |
My guess would be that subcommands are called with handleExecutionErrors set to true. Should be false so that the exception gets rethrown and reaches the proper scope.
I can take a look tonight.
…________________________________
From: Cohee ***@***.***>
Sent: Thursday, May 16, 2024 1:00:39 PM
To: SillyTavern/SillyTavern ***@***.***>
Cc: Len ***@***.***>; Mention ***@***.***>
Subject: Re: [SillyTavern/SillyTavern] [BUG] Unexpected behavior with subcommand in quotes (Issue #2254)
@LenAnderson<https://github.com/LenAnderson> does the abort not immediately stop the execution in the new parser when encountered in a subcommand?
—
Reply to this email directly, view it on GitHub<#2254 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABWRMQB4D5WYQYOGXLITFKLZCTQ3PAVCNFSM6AAAAABH2SDEVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVG43TINJUGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Cohee1207
added a commit
that referenced
this issue
May 17, 2024
I believe that's all to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
📱 Termux
System
Mull 125.3.0
Version
SillyTavern 1.12.0-preview 'staging' (517da9f)
Desktop Information
No response
Describe the problem
The exection goes through despite using /abort with quotes. {: ... :} works fine though.
Additional info
Please tick the boxes
The text was updated successfully, but these errors were encountered: