Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some checkboxes in TTS options aren't working #2234

Closed
3 tasks done
bobcate opened this issue May 14, 2024 · 2 comments
Closed
3 tasks done

[BUG] Some checkboxes in TTS options aren't working #2234

bobcate opened this issue May 14, 2024 · 2 comments
Labels
馃悰 Bug [ISSUE] Ticket describing something that isn't working 馃獰 Windows [ISSUE] The Environment is on Windows

Comments

@bobcate
Copy link

bobcate commented May 14, 2024

Environment

馃獰 Windows

System

Thorium v123.0.6312.133

Version

SillyTavern 1.11.8 'release' (204a934)

Desktop Information

No response

Describe the problem

Some checkbox settings in "SillyTavern > Extensions > TTS" aren't working.
Using AllTalk-tts.

Steps to reproduce:

  1. Set up SillyTavern and AllTalk to work together
  2. Go to "SillyTavern > Extensions > TTS", enable AllTalk
  3. Check Ignore *text, even "quotes", inside asterisks* and Skip codeblocks
  4. Open browser console
  5. Edit the first message as `test 1` *"test2"*
  6. Click the Narrate button
  7. Observe the browser console, the texts are still passed to the tts server and vocalized

Unless I'm not getting the meanings of those checkboxes, if they were working, nothing would be sent to the tts server.

Additional info

I reported this issue to AllTalk first and the dev said those options were managed by SillyTavern. If this is something that requires work on AllTalk, please continue from that ticket.

Please tick the boxes

@bobcate bobcate added the 馃悰 Bug [ISSUE] Ticket describing something that isn't working label May 14, 2024
@github-actions github-actions bot added the 馃獰 Windows [ISSUE] The Environment is on Windows label May 14, 2024
@Cohee1207
Copy link
Member

Can't see a bug here.

  1. `this` is not a code block, it's an inline code element. And it's not controlled by the setting.
  2. "Pass Asterisks to TTS Engine" verify that this setting is disabled. As I wasn't able to reproduce with this off, but when it's on - the text insight of the asterisks is narrated as it should.

@bobcate
Copy link
Author

bobcate commented May 15, 2024

Thank you for the clarification. I didn't know 1 was called a different name; and in 2, Pass Asterisks to TTS Engine have precedence over Ignore *text, even "quotes", inside asterisks*.

Issue resolved, but if you're interested, please keep reading to see why I was trying to use those checkboxes, maybe you'll consider adding a feature.

I'm experimenting with different visual promt formats, trying to see what looks good.
The stucture I decided on was Response: *action* "dialogue *"inner voice"*
Then I discovered AllTalk, which uses 2 different voices, one for narrator, one for character.
The *"inner voice"* in the response doesn't belong to the narrator, and also the character shouldn't vocalize it since it's not spoken. (wish there was a third voice)
So, I wanted the Ignore *text, even "quotes", inside asterisks* box to prevent it's passage to the tts server.
The inline code element was part of my experiment, trying to find an alternative way to display the inner voice while not vocalizing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Bug [ISSUE] Ticket describing something that isn't working 馃獰 Windows [ISSUE] The Environment is on Windows
Projects
None yet
Development

No branches or pull requests

2 participants