Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Summarizable and toArray #69

Open
Sibyx opened this issue Oct 1, 2023 · 2 comments
Open

Removal of Summarizable and toArray #69

Sibyx opened this issue Oct 1, 2023 · 2 comments

Comments

@Sibyx
Copy link
Owner

Sibyx commented Oct 1, 2023

As part of the new major release, I propose the removal of the Summarizable interface along with its toArray method. This decision stems from my belief that all models should instead implement the JsonSerializable interface, thereby returning a GeoJSON compatible result where feasible.

The usage of arrays in this context seems antiquated and unnecessarily complex, hence it doesn't align with the direction of our project. I anticipate that the removal of these features won't be a significant loss for the users. However, I welcome any thoughts and potential concerns about this proposed change.

Originally posted by @Sibyx in #67 (comment)

@miqwit
Copy link
Contributor

miqwit commented Mar 8, 2024

Exporting in GeoJSON is a must. This library could then act as a GPX to GeoJSON converter (like some others - not much - but with the other features like the stats that make this library charming).

@Sibyx
Copy link
Owner Author

Sibyx commented Mar 8, 2024

Yep, totally agree. There is already some implementation started in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants