Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen should be dynamic, we can create screen and targeting platform #27

Open
tyohan opened this issue Jan 11, 2017 · 6 comments
Open

Comments

@tyohan
Copy link
Contributor

tyohan commented Jan 11, 2017

For now screen is fix and view more link only work on android not on web. Ideally we should able to create any screen we want and targeting specific platform either android, ios, or web.

@prashantsh
Copy link

@tyohan Do you mean, similar to Journey, Home and Country screen, we should be able to create any number of screens? At the moment since the navigation of the app is fixed, we have made the number of screens fixed as per the navigation. Also the app and the web app is using the same API so the screens are same for all platform. we can make the screen dynamic, but not sure if this is needed immediately.

@tyohan
Copy link
Contributor Author

tyohan commented Jan 11, 2017

The problem is we can't use view more link on both platform. I think most important one is either we set through block or through screen that this for Android or this one for web. For now view more only set to android and doesn't work on web.

@prashantsh
Copy link

@tyohan I had a chat with the team on that issue today and we think we can fix that issue for the web app. For read more page we have made a category page api which will show content based on the category ids which we pass. so we should be abe to use that for read more for web and android.

@tyohan
Copy link
Contributor Author

tyohan commented Jan 12, 2017

@prashantsh how if the block filtered by category and country like the example that we have now. If view more only linked to category feed then it's not consistent with the thing that we show on the block.

@prashantsh
Copy link

@tyohan The view more feed will be linked to category and the country like we have in the block so it will be the same feed as we have in the block but with more items.

@tyohan
Copy link
Contributor Author

tyohan commented Jan 12, 2017

@prashantsh me and shankar will have a call either today or tonight to discuss about this screen and block. Will back to you shortly after we have something. In the meantime please hold this one. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants