Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug / UI : Colours crossed out still selectable #6

Open
Lewiscowles1986 opened this issue Feb 13, 2019 · 1 comment
Open

Bug / UI : Colours crossed out still selectable #6

Lewiscowles1986 opened this issue Feb 13, 2019 · 1 comment
Labels
a11y Accessibility implementation invalid This doesn't seem right

Comments

@Lewiscowles1986
Copy link

when using the https://ecommerce-vue-nuggets.herokuapp.com/ variance selector for colour, even if the colour visually looks disabled, I can still select it and interact with it as-if it were a valid choice.

Why report this

This is confusing for the end user

Expected behaviour

  • tab-selectable & keyboard interaction with colour variant
  • disabled / not available variant cannot be selected or tabbed to (standard form behaviour)
  • use of custom-styled form-elements with labels for accessibility
@Shreerang
Copy link
Owner

Let's address the 2 things here -

First things first. Accessibility is not implemented for any of the components. I am actively working on fixing it. It is on my priority list.

As far as the selecting "unavailable color" is concerned, it is valid feature and not really a bug. On an e-commerce site, the color picker usually works in combination with the size picker. A lot of times, you pick a color and see what sizes are available and vise versa. Also even if a color is unavailable, numerous sites allow you to add that product to wishlist so that the user can be notified when that product in the particular, currently "unavailable" color becomes available.

The unavailable color and size are both represented differently from available colors and sizes. They will also be read differently for screen readers (yet to be implemented.)

@Shreerang Shreerang added invalid This doesn't seem right a11y Accessibility implementation labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility implementation invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants