Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with "node_modules" is getting filtered #986

Open
andershagbard opened this issue Jan 2, 2023 · 0 comments
Open

Files with "node_modules" is getting filtered #986

andershagbard opened this issue Jan 2, 2023 · 0 comments

Comments

@andershagbard
Copy link

Describe the bug
If you have a file names node_modules_my-file.js Theme Kit will prevent any action against this file. This is because it's filtered in file/filter.go. I don't see why this would be the case.

I can see why it would filter a folder called "node_modules" under a "Shopify folder" (assets, templates, layouts, etc), but I can't see why it would filter a file called this.

But Anders, why in the world would you call your files something with "node_modules"?

I use a common setup, with webpack, babel and core-js, and utilize import functions. core-js modules will be imported as modules, and in dev mode, they will be named something like this: node_modules_core-js_modules_web_url-search-params_js.js.

Obviously there are hacky workarounds, but I hope Shopify will take this seriously, and get it fixed asap.

To Reproduce
Steps to reproduce the behavior:

  1. run command theme watch
  2. Create a file called assets/node_modules_my_file.js

Expected behavior
I would expect this file to be uploaded.

Environment:

  • Themekit version (run theme version to check): ThemeKit 1.3.1 darwin/amd64
andershagbard added a commit to andershagbard/themekit that referenced this issue Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant