Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile themekit for M1 Macs #971

Open
adrianocr opened this issue Mar 26, 2022 · 1 comment
Open

Compile themekit for M1 Macs #971

adrianocr opened this issue Mar 26, 2022 · 1 comment

Comments

@adrianocr
Copy link

adrianocr commented Mar 26, 2022

Is your feature request related to a problem? Please describe.
Currently themekit on Macs is limited to amd64 which runs OK-ish within Rosetta but performance is not great and I've had several console errors related to timed out deployments.

Describe the solution you'd like
Add darwin/arm64 to list of binaries to build

Additional context
I managed to compile it myself but ran into an issue with Go 1.18 due to an apparent issue with golang.org/x/sys/unix. The errors were:

../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:136:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:151:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:166:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190412213103-97732733099d/unix/zsyscall_darwin_arm64.go:166:3: too many errors

So I installed a separate copy of Go 1.16.10 and compilation worked fine. Inside the themekit directory running export GOOS=darwin GOARCH=arm64 && ~/go/bin/go1.16.10 build -o theme cmd/theme/main.go correctly compiles a themekit binary which the command ./theme version outputs the response ThemeKit 1.3.0 darwin/arm64

@adrianocr adrianocr changed the title Compiled themekit for M1 Macs Compile themekit for M1 Macs Mar 26, 2022
@rmontero
Copy link

rmontero commented Dec 8, 2023

Bump this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants