Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions are unavailable until file is saved #1908

Open
andyw8 opened this issue Apr 10, 2024 · 0 comments
Open

Completions are unavailable until file is saved #1908

andyw8 opened this issue Apr 10, 2024 · 0 comments
Labels
bug Something isn't working pinned This issue or pull request is pinned and won't be marked as stale server This pull request should be included in the server gem's release notes

Comments

@andyw8
Copy link
Contributor

andyw8 commented Apr 10, 2024

Currently we only index when a file is saved, meaning that completions will be unavailable for newly-added symbols within the same file. This could be unexpected, especially if people are coming from other editor setups which behave differently.

A couple of options that come to mind:

  • Index the current file on changes
  • Index the current file on-the-fly when the completion is triggered

We should also consider the case of multiple unsaved files, with one referencing the other.

@andyw8 andyw8 added bug Something isn't working server This pull request should be included in the server gem's release notes labels Apr 10, 2024
@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned This issue or pull request is pinned and won't be marked as stale server This pull request should be included in the server gem's release notes
Projects
None yet
Development

No branches or pull requests

2 participants