Segfault RNSkia::RNSkOpenGLCanvasProvider::surfaceSizeChanged

[hannojg]

Description

We are seeing crashes in sentry from react-native-skia on android.

We are also seeing another stack around, which is maybe related:

Version

1.2.3

Steps to reproduce

Sorry, this is where it gets vague 🙇
We can't reproduce the crash on our phones.

All we know is that the crash happens when we navigate away from a screen where we render a rnskia surface.

Note: we see the crash happening also on earlier versions of skia. It was first reported to us in sentry on rnskia version: 1.0.4

Snack, code example, screenshot, or link to a repository

The stack is unfortunately not very long, I understand that a full reproduction is needed to help address that quickly. I just wanted to share the stack here, maybe you know from looking at the stack what could cause the crash?

[wcandillon]

This is interesting. There might be a bug on our side.
I am reviewing a couple of possible flow where this error could happen (surfaceDestroyed being invoked before surfaceSizeChanged, which may not be impossible due to some RN-Screens extra handling we're doing there).
if we were to throw an error there instead of segfaulting that would already be useful right?

If cannot find anything obvious, would it be possible to review the app code privately? I would like to check which APIs are used and how they are being used. Do you have anything exotic there?

[hannojg]

would it be possible to review the app code privately?

Yes, we'd appreciate that! I send you a message on slack, thanks @wcandillon

We are not doing anything crazy, mostly just using the declarative react API.