Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-mini-transforms - Use stripIgnoredCharacters to minimize the source (Instead of bespoke regex) #2686

Open
2 tasks done
steven-hoffman-jomashop opened this issue Sep 12, 2023 · 0 comments
Labels
Type: Enhancement 📈 Enhancement to our codebase

Comments

@steven-hoffman-jomashop

Overview

graphql-mini-transforms - Use graphql's stripIgnoredCharacters to minimize the source (Instead of bespoke regex)

Motivation

graphql version 14.3.0 Added the 'stripIgnoredCharacters utility function'
This can be used instead of the bespoke regex used in minifySource
This change will remove some bespoke regex and use a more 'standard' minimization function.

Notes

  • Current minimum dependency for graphql is >=14.50
  • Many documents will not have their hash change; some will have their hash change.

Scope

  • Package: graphql-mini-transforms

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
@steven-hoffman-jomashop steven-hoffman-jomashop added the Type: Enhancement 📈 Enhancement to our codebase label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement 📈 Enhancement to our codebase
Projects
None yet
Development

No branches or pull requests

1 participant