New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain DOM tree when top bar is undefined in reframe #11998

Draft

sophschneider wants to merge 1 commit into main from reframe-maintain-tree

Contributor

sophschneider commented May 9, 2024 •

edited

WHY are these changes introduced?

Part of https://github.com/Shopify/polaris-backlog/issues/1610
Fixes https://github.com/Shopify/polaris-backlog/issues/1609

WHAT is this pull request doing?

Conditionally rendering the frame wrapper classes depending on the topBar prop was causing Frame's children to unmount when Frame's props changed. This was causing a bug for full screen pages in the admin because they changed the fullscreen state on unmount.

Only changing classnames for the frame's wrapper classes ensure that the children do not unmount when topBar becomes undefined

How to 🎩

press fullscreen button
Make sure analytics goes full screen

press customize button
make sure online store editor loads properly

🎩 checklist

Tested a snapshot
Tested on mobile
Tested on multiple browsers

Contributor Author

sophschneider commented May 9, 2024

/snapit

sophschneider force-pushed the reframe-maintain-tree branch from a7e66a9 to 00fe30f Compare

May 9, 2024 15:30

Contributor Author

sophschneider commented May 9, 2024

/snapit

Contributor

github-actions bot commented May 9, 2024

🫰✨ Thanks @sophschneider! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240509153439"

sophschneider force-pushed the reframe-maintain-tree branch from 00fe30f to c4cf479 Compare

May 9, 2024 17:17

Contributor Author

sophschneider commented May 9, 2024

/snapit

Contributor

github-actions bot commented May 9, 2024

🫰✨ Thanks @sophschneider! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240509173401"

sophschneider force-pushed the reframe-maintain-tree branch from c4cf479 to 2318df4 Compare

May 9, 2024 17:57

sophschneider changed the title ~~Maintain DOM ordering when top bar is undefined in reframe~~ Maintain DOM tree when top bar is undefined in reframe

Contributor Author

sophschneider commented May 9, 2024

/snapit

Contributor

github-actions bot commented May 9, 2024

🫰✨ Thanks @sophschneider! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240509180633"

sophschneider closed this

sophschneider reopened this

Contributor Author

sophschneider commented May 10, 2024

/snapit

Contributor

github-actions bot commented May 10, 2024

🫰✨ Thanks @sophschneider! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240510034702"


          Maintain DOM ordering when top bar is undefined in reframe

7c1af27

sophschneider force-pushed the reframe-maintain-tree branch from 2318df4 to 7c1af27 Compare

May 10, 2024 03:56

Contributor Author

sophschneider commented May 10, 2024

/snapit

Contributor

github-actions bot commented May 10, 2024

🫰✨ Thanks @sophschneider! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240510035701"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment