Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs component response to a breakpoint #11952

Open
Jurgyte opened this issue Apr 26, 2024 · 0 comments
Open

Tabs component response to a breakpoint #11952

Jurgyte opened this issue Apr 26, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@Jurgyte
Copy link

Jurgyte commented Apr 26, 2024

Summary

In AppBridge modal Tabs are rendered as they would be in a mobile with dropdown on the right. After any change in the screen or resize it falls back to normal view. It is happening in any size of the modal.

Initial screen:
Screenshot 2024-04-26 at 23 23 37

It seems that it is rendered before the screen gets it's size and it is rendered as in a very small screen.

The initial conversation:
https://shopify.slack.com/archives/C4Y8N30KD/p1713874644325089?thread_ts=1712755920.322749&cid=C4Y8N30KD

Expected behavior

I think it should not jump and change looks. I found out, that if we render tabs after modal i loaded it shows tabs as expected, however this rendering logic feels like extra step which could be avoided.

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Description of what the gif shows

Steps to reproduce

  1. Create an AppBridge modal.
  2. Add Tabs component.

Are you using React components?

Yes

Polaris version number

12

Browser

Chrome

Device

Macbook

@Jurgyte Jurgyte added Bug Something is broken and not working as intended in the system. untriaged labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant