[Icon] add LocationIssue and LocationValid icons #11940
Conversation
JordanForeman
force-pushed
the
add-location-major-icon
branch
from
e28d75b
to
37b6a87
Compare
cc. @sam-b-rose Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
|
@sam-b-rose thanks for the suggestions and optimizations! I've incorporated your feedback on the |
There was a problem hiding this comment.
@JordanForeman what is the timeline/urgency for these icons? We are building a new icon library to replace this one.
|
I just realised that the location icons are updated since we first created the icons. So, I just updated the icons and respective issues with to reflect the latest icon designs. |
|
@alex-page I'd say "medium" urgency? We're aiming for mid-May to start using this. I'm not sure we'll have time to include migration to a new icon library, depending on the costs associated with that. |
|
@JordanForeman is there any blockers or things stopping you from using the icons without polaris-icons until the new library is implemented? |
|
@alex-page nope 馃槃 I can just hardcode these for now, and we can keep tabs on how icons evolves. |
WHY are these changes introduced?
resolves #11939
resolves #11938
WHAT is this pull request doing?
Adds a new icons to the
polaris-iconspackage.cc. @ksvihar
How to 馃帺
馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
馃帺 checklist
README.mdwith documentation changes