Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visuals and improved guidance for Banner when used within a Card #11848

Open
sam-b-rose opened this issue Apr 5, 2024 · 0 comments
Open

Comments

@sam-b-rose
Copy link
Member

There is a bit of confusion with how using a Banner within a Card changes the appearance. We have some info on this, but it is mixed with other component guidance. Having images or rendered examples inline with the guidance would be a helpful way to highlight how the design changes based on context.

Suggestion:

  • Add inline images showcasing the different banner styles based on context
  • Make this information more prominent by separating it out of the bulleted list into its own section

Related issue: #1303comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant