Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script component #38

Closed
Tracked by #153
benjaminsehl opened this issue Sep 23, 2022 · 4 comments
Closed
Tracked by #153

Script component #38

benjaminsehl opened this issue Sep 23, 2022 · 4 comments
Assignees

Comments

@benjaminsehl
Copy link
Member

benjaminsehl commented Sep 23, 2022

Whether or not we leverage it, the impact Partytown can provide (or Zaraz or whatever) for improving the performance impact of third party pixels is a huge point for performance of 2.0

@benjaminsehl benjaminsehl added this to the 2. Hydrogen 2.0 milestone Sep 23, 2022
@juanpprieto juanpprieto self-assigned this Oct 11, 2022
@benjaminsehl benjaminsehl changed the title Script (Partytown) Script component (Partytown-like) Nov 7, 2022
@benjaminsehl benjaminsehl changed the title Script component (Partytown-like) Script component Nov 7, 2022
@benjaminsehl benjaminsehl removed this from the 2. Hydrogen 2.0 milestone Nov 7, 2022
@blittle
Copy link
Contributor

blittle commented Nov 29, 2022

Maybe reuse what is already in H1?

@blittle
Copy link
Contributor

blittle commented Nov 29, 2022

@benjaminsehl
Copy link
Member Author

This feels like it should be done at the Remix layer, not ours — but if we need to do something short term here, I'm open to that. @frandiox was exploring this I believe, based on @juanpprieto's H1 work.

If we have something close, that we're confident would be great in a 2.0 release, I'm OK to keep this on the roadmap — but for now am moving it to stopped for the above reason.

@frandiox
Copy link
Contributor

frandiox commented Jan 3, 2023

This was basically stopped right after I was assigned so there's not much work done here (apart from that JPP did for H1).
Perhaps we should talk with the Remix folks to see if we redirect the efforts there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants