Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds scriptSrcElem to the CreateContentSecurityPolicy type #2105

Merged
merged 2 commits into from May 14, 2024

Conversation

altonchaney
Copy link
Contributor

@altonchaney altonchaney commented May 10, 2024

WHY are these changes introduced?

Providing a scriptSrcElem list to the createContentSecurityPolicy function fails type checking.

WHAT is this pull request doing?

Adds type support for the script-src-elem directive for CSPs

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@altonchaney
Copy link
Contributor Author

I have signed the CLA!

@juanpprieto
Copy link
Contributor

juanpprieto commented May 13, 2024

Thanks for the contribution altonchaney!

Could you please add a patch changeset targetting @shopify/hydrogen?

npm run changeset at the root

@altonchaney
Copy link
Contributor Author

@juanpprieto thanks for the heads up, added the changeset!

@blittle blittle merged commit 8eea75e into Shopify:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants