Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up for graphql-codegen dependency pump in examples folder #2101

Merged
merged 1 commit into from May 10, 2024

Conversation

michenly
Copy link
Contributor

@michenly michenly commented May 9, 2024

Cont' to #2094

codegne generated files need to be updated from the graphql-codegen dependency as well.

@michenly michenly requested a review from a team May 9, 2024 19:24
@michenly michenly self-assigned this May 9, 2024
Copy link
Contributor

shopify bot commented May 9, 2024

Oxygen deployed a preview of your mc-graphql-codegen-con branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 9, 2024 7:25 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget about non-diff examples 🙈

@michenly
Copy link
Contributor Author

@frandiox actually, not all of the examples are non-diff!

A few have graphql changes in the example so the x-generated.d.ts files were checked in and had to get change anyway.

@michenly michenly merged commit 55378a4 into main May 10, 2024
12 checks passed
@michenly michenly deleted the mc-graphql-codegen-con branch May 10, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants