Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart.cost is sometimes undefined #2034

Open
nik0kin opened this issue Apr 24, 2024 · 0 comments
Open

Cart.cost is sometimes undefined #2034

nik0kin opened this issue Apr 24, 2024 · 0 comments
Labels
cart Storefront API Issues related to https://shopify.dev/docs/api/storefront

Comments

@nik0kin
Copy link

nik0kin commented Apr 24, 2024

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2024.1.5

What version of Remix are you using?

2.8.0

Steps to Reproduce

Unknown

Expected Behavior

https://github.com/Shopify/hydrogen/blob/main/packages/hydrogen-react/src/storefront-api-types.d.ts#L553 Cart.cost should be marked as optional

Actual Behavior

Cart.cost is not always defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cart Storefront API Issues related to https://shopify.dev/docs/api/storefront
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michenly @nik0kin