Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hydrogen Skeleton] There is no collections/all page in the Hydrogen skeleton like there is for Liquid #1761

Open
BrendaSegalShopify opened this issue Feb 14, 2024 · 2 comments

Comments

@BrendaSegalShopify
Copy link

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

xxxx

What version of Remix are you using?

No response

Steps to Reproduce

cc @juanpprieto this is the issue covering what we discussed in our Hydrogen Developer Tools research meeting.

Visiting /collections/all on my Hydrogen storefront leads to a 404

Expected Behavior

In Liquid, Shopify has a default /collections/all that returns all products, regardless of collections.

If available through the Storefront API, we should have a way to do something similar in Hydrogen.
Note that if the merchant creates a collection called all, /collections/all should route to that collection, not to the default /collections/all (all products). This would be consistent with the behaviour in Liquid.

Actual Behavior

already described

@BrendaSegalShopify BrendaSegalShopify changed the title There is no collections/all page in the Hydrogen skeleton like there is for Liquid [Hydrogen Skeleton] There is no collections/all page in the Hydrogen skeleton like there is for Liquid Feb 14, 2024
@jamalsoueidan
Copy link
Contributor

jamalsoueidan commented Apr 11, 2024

#1967

@jamalsoueidan
Copy link
Contributor

jamalsoueidan commented Apr 11, 2024

I think it's missing:

Note that if the merchant creates a collection called all, /collections/all should route to that collection, not to the default /collections/all (all products). This would be consistent with the behaviour in Liquid.

@juanpprieto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants