Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX issue with the country selector on mobile #34

Open
therealchrisrock opened this issue Jan 29, 2024 · 1 comment
Open

UI/UX issue with the country selector on mobile #34

therealchrisrock opened this issue Jan 29, 2024 · 1 comment

Comments

@therealchrisrock
Copy link

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2024.01.01

What version of Remix are you using?

2.5.1

Steps to Reproduce

  1. go to the online demo store example
  2. Reduce screen size to mobile view width.
  3. Click the country selector in the footer
  4. Observe styling issue

Expected Behavior

Fly-out menu for countries should be fully visible.

The following updates may fix this:

  1. Fly-out menu should have a non-transparant backgrond.
  2. Fly-out menu opens above the trigger rather than below it.

Actual Behavior

  1. Fly-out menu is cut off, extending past bottom of the page.
  2. Fly-out menu has transparant background so menu items are obscured by the element behind it.

image

@therealchrisrock
Copy link
Author

By the way, I'd love an opportunity to make a contribution. If you are open to new contributors and have specific recommendations for the UI changes, please let me know.

@michenly michenly transferred this issue from Shopify/hydrogen May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant