Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing the cursor and merge it back with the DataIterator #306

Open
shuhaowu opened this issue Sep 21, 2021 · 0 comments
Open

Comments

@shuhaowu
Copy link
Contributor

We used to iterate through the data directly in the DataIterator. At one point, we developed the IterativeVerifier, which caused us to refactor the DataIterator such that the data iteration part became a Cursor, so it can be reused by the IterativeVerifier. With the InlineVerifier superseding the IterativeVerifier, the need for such a Cursor has been eliminated. To simplify the codebase, we should merge the functionality of Cursor back into the DataIterator.

We also need to remove the IterativeVerifier after that. See this outdated PR for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant