You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there anyone on the Shopify Dawn team who was part of the original typography design for Dawn? Is it just me or is the CSS unusually complex for the typography?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Is there anyone on the Shopify Dawn team who was part of the original typography design for Dawn? Is it just me or is the CSS unusually complex for the typography?
For example, why is the base font size specified with a calculation in the head of theme.liquid? https://github.com/Shopify/dawn/blame/afa073abd018f78e1b9883dd1fba1b5364b1e28a/layout/theme.liquid#L229
Is that because it needed to pull from the theme settings? Surely there’s a more elegant way to do this.
Beta Was this translation helpful? Give feedback.
All reactions