[Bug]: shopify theme push isn't working on 3.59.0 again

[xmadscientist]

Please confirm that you have:

• Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
• Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Push changed files.

Actual behavior

Not pushing changed files.

Verbose output

https://pastebin.com/Yq4L6Kjz

(output was too long to open a ticket)

Reproduction steps

1. shopify theme push -e=env_name --allow-live

Operating System

Mac OS Ventura

Shopify CLI version (check your project's package.json if you're not sure)

3.59.0

Shell

zsh

Node version (run node -v if you're not sure)

v14.18.3

What language and version are you using in your application?

N/A

[mgmanzella]

👋 hi @xmadscientist thank you for reporting this issue, would you mind rerunning the command you shared but with --verbose and then sharing the logs output in your terminal? we need this information in order to debug:

shopify theme push -e=env_name --allow-live --verbose

thank you for your help 🙏

[stijns96]

Same here.

I use

config/settings_data.json
templates/**/*.json

# Ignore all locale files except en-dev.default.json
!locale/*.json
locale/en-dev.default.json

Somehow, !locale/*.json is causing the issue. This worked before.

[mgmanzella]

@stijns96 we've identified the root cause of the issue you're experiencing and working on a fix

@xmadscientist the issue you reported may be different, please still share your verbose logs (the pastebin you shared seems to have been truncated)

[stijns96]

Hi @mgmanzella,

When can we expect a fix? For our agency it's quite crucial to get the ignore file on point. Otherwise we are overwriting the content of our clients... Previously we used /(locales\/)(?!en-dev.default.json)/, but this doesn't seem to work anymore as well.

[mgmanzella]

i don't have a time estimate on when this will be fixed, we're working through edge cases of glob matching being different in the TS implementation of theme push vs Ruby.

try using the --stable flag with your command, it should allow it to work as expected but let us know if it doesn't 🙏

[CodeBrotha]

Same problem here. This bug was flagged previously in 3.58.0 and was fixed in 3.58.2 here is the previous issue.

It seems that fix was reverted for some reason.

[jamesmengo]

@CodeBrotha could you please provide verbose logs and a description of the issue?

[CodeBrotha]

@jamesmengo Sorry I was busy the past few days, however I just updated to to 3.59.1 which reverted shopify theme push back to the state of your fix from version 3.58.2.

It is working as expected again.