[Feature]: Ignore globs from .gitignore when looking for shopify.web.toml
#3702
Labels
Type: Enhancement
New feature or request
shopify.web.toml
#3702
What area(s) will this request affect?
Deployment
What type of change do you want to see?
New feature
Overview
I'm currently using sst.dev to deploy some of my infrastructure to support our Shopify app. I notice that sst will copy the
shopify.web.toml
file multiple time to it's local cache directory located at.sst/
.After a sst deploy if I run
shopify app deploy
it will throw an error saying "You can only have one web with the backend role in your app"On further inspection I noticed that the function
loadWebs
will automatically look for anyshopify.web.toml
file. If I look at the value ofwebTomlPaths
in that function I can see it found the following paths:./myapp/shopify.web.toml
./myapp/.sst/dist/asset.1c2820b0c6ebda7219ed80571b3403754fad21f218a63c84f4c2343838f6c325/shopify.web.toml
./myapp/.sst/dist/asset.26364bf4695807ba459400fe064778d5687f8f8568eb65e9ebcbd5e65106cc6f/shopify.web.toml
./myapp/.sst/dist/asset.b13cfda5f566a8a060902ce8e5de6140482397ca4f5b7000858edfb54a0ce02c/shopify.web.toml
./myapp/.sst/dist/asset.e92036fdbd0dbc9c73bc238a935ab561ced0076bb90cf3cd8fdb4c6541295cc6/shopify.web.toml
It would be nice if there was a way to have the contents of
.gitignore
added towebConfigGlobs
so that it would ignore any other cases like this. Personally I would always want it to use.gitignore
but I imagine there are cases where someone would want that to be configurable.This might also be classified as a bug, but I figured it was a bit of an edge case.
I'm also happy to open a PR around this if it's something ya'll deem useful. My workaround at the moment is to force delete the .sst directory before running
shopify app deploy
in our ci/cd pipeline.Motivation
I was running into this issue when trying to run
shopify app deploy
while also working with sst.dev. Figured it would be something that others might run into.The text was updated successfully, but these errors were encountered: