Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GitHub Integration does not obey .gitignore #3587

Open
2 tasks done
nboliver-ventureweb opened this issue Mar 20, 2024 · 1 comment
Open
2 tasks done

[Bug]: GitHub Integration does not obey .gitignore #3587

nboliver-ventureweb opened this issue Mar 20, 2024 · 1 comment
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Bug Something isn't working

Comments

@nboliver-ventureweb
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

The GitHub integration does not obey .gitignore files. This has the side effect of files that should not be in the git repo being committed by Shopify. Examples of this type of file are built assets. The expected behaviour is that any file in a repo's .gitignore file should not be forced back into the repo if it exists in the theme (and not in the repo).

There are numerous community posts reporting the same issue:
https://community.shopify.com/c/technical-q-a/github-integration-doesn-t-support-the-gitignore-file/m-p/1253056
https://community.shopify.com/c/technical-q-a/github-integration-ignores-shopifyignore/td-p/2407792
Not sure if this is the right place to report this, but I don't see an alternative, so hopefully it ends up with the right team.

Actual behavior

Shopify GitHub integration forces ignored files to be tracked.

Verbose output

n/a

Reproduction steps

  1. Create a .gitignore file and add some entries to it
  2. Hook up your branch to Shopify via GitHub integration
  3. Deploy an (or create) an ignored file to the connected theme
  4. Watch the integration force the file to be tracked in git

Operating System

Mac OS Ventura

Shopify CLI version (check your project's package.json if you're not sure)

3.50.0

Shell

zsh

Node version (run node -v if you're not sure)

v18.16.0

What language and version are you using in your application?

No response

@nboliver-ventureweb nboliver-ventureweb added the Type: Bug Something isn't working label Mar 20, 2024
@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Mar 22, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants