Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: theme dev throws 404 because of missing video in disabled section #3586

Open
2 tasks done
vaelu opened this issue Mar 20, 2024 · 2 comments
Open
2 tasks done
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Bug Something isn't working

Comments

@vaelu
Copy link

vaelu commented Mar 20, 2024

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

theme dev should ignore sections which are disabled and not throw a 404 on the whole page.

Actual behavior

We had a disabled video section in a template, and this video was deleted from Shopify. When I ran shopify theme dev it started the theme with a 404 page (possibly because it was in the index.json template).

Verbose output

Original output (german):
templates/index.json: Der Wert in der Einstellung "video" verweist nicht auf eine anwendbare, von Shopify gehostete Videoressource.
  • 22:36:14 ERROR  » update templates/index.json:

Translated:
templates/index.json: The value in the setting "video" does not point to an applicable video resource hosted by Shopify.
  • 22:36:14 ERROR  » update templates/index.json:

Reproduction steps

  1. Create a section and add a video to it
  2. Disable this section and delete the video from Shopify's files
  3. Try to start the theme with theme dev

Operating System

MacOS Sonoma 14.4

Shopify CLI version (check your project's package.json if you're not sure)

3.57.1

Shell

zsh

Node version (run node -v if you're not sure)

v21.2.0

What language and version are you using in your application?

No response

@vaelu vaelu added the Type: Bug Something isn't working label Mar 20, 2024
@lvl99
Copy link
Contributor

lvl99 commented Mar 22, 2024

I just want to add my 2c here: when we're working on multiple stores with the same codebase, often files won't exist and it is a real pain when trying to push something like templates/index.json (especially when those files are large videos). It's a nice feature that it can provide an error, but I wish it wasn't a blocking error and was more of a warning.

What would actually be great is if we could have shared files across all linked stores (e.g. we're on Shopify Plus and this would be a super great feature), and maybe the ability to configure which stores can have shared files. But I realise this is well outside of the scope of the Shopify CLI 😅

@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Mar 22, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants