Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages with characters built from multiple keypresses (e.g. Korean) don't display a character in the web/electron edit box until it has been completed #728

Closed
tec27 opened this issue Jul 9, 2021 · 1 comment

Comments

@tec27
Copy link
Member

tec27 commented Jul 9, 2021

Reported by LEXUS:

korean letters don't type properly on ShieldBattery, it shows the IME box preview in the top left and you can still type, but you can't see what you're typing until the character is finished

Pretty sure this is due to use using a controlled input here and either not handling the proper events or React not delivering the necessary events

facebook/react#3926 is probably related and may have a fix (haven't done more than skim it yet)

@tec27 tec27 changed the title Languages with characters built from multiple keypresses (e.g. Korean) don't display a character in the edit box until it has been completed Languages with characters built from multiple keypresses (e.g. Korean) don't display a character in the web/electron edit box until it has been completed Jul 9, 2021
@tec27
Copy link
Member Author

tec27 commented Sep 9, 2021

Tested across multiple users and seems to be working fine, not sure if this is something we/React/Electron fixed without us knowing, or this was just a user-specific issue 🤷‍♂️

@tec27 tec27 closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant